fix(agents-api): remove agent participants from session_lookup on agent delete#1597
Open
haroldfabla2-hue wants to merge 1 commit intojulep-ai:devfrom
Open
fix(agents-api): remove agent participants from session_lookup on agent delete#1597haroldfabla2-hue wants to merge 1 commit intojulep-ai:devfrom
haroldfabla2-hue wants to merge 1 commit intojulep-ai:devfrom
Conversation
Fixes orphan sessions when delete_agent is called. When an agent is deleted, its session_lookup entries were not being removed, causing orphan sessions that reference a deleted agent. This adds a CTE to delete session_lookup entries where participant_type='agent' and participant_id=agent_id before deleting the agent itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When deleting an agent,
session_lookuprows with that agent as participant were not removed.This leaves orphan session-participant mappings and causes inconsistent session state.
Changes
deleted_session_lookupCTE indelete_agentqueryparticipant_type = 'agent'participant_id = agent_iddeveloper_id = developer_idWhy
Issue #1550 reports orphan sessions after
delete_agent.This fix ensures participant references are cleaned up atomically in the same query.
Fixes #1550