Conversation
Collaborator
Author
|
Bumping parent to pom-scijava-37.0.0 causes the following test failures with @ctrueden any idea what could be going on there and how to fix it? |
imglib2 -> 7.1.0 imglib2-realtransform -> 4.0.3 imglib2-roi -> 0.15.0 imglib2-cache -> 1.0.0-beta-18 imglib2-algorithm -> 0.15.3 bigdataviewer-core -> 10.6.0
tpietzsch
force-pushed
the
feature-rai-getType
branch
from
c9a8eaa to
2fc86c5
Compare
Collaborator
|
@tpietzsch Thank you for the PR !! What are the steps and timing required to get this released & deployed together with imglib2-7.1 ? |
Collaborator
Author
|
It would be cool if you could make a release now. I'll ping you when the imglib2-7.1 is on the Fiji update site |
In imglib2-7.1 the way Utils.getTypeFromInterval(...) works was changed. Currently it triggers a NullPointerException for an ImgLabeling. This workaround fixes the problem.
Collaborator
|
A made the releases:
@tpietzsch Could you please upload the labkit jars together with imglib2, I don't yet have the privileges to upload to Fiji's core update sites. I also found a bug in imglib2-roi - imgLabeling.getType(). Even after fixing the bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes that will be required after imglib/imglib2#312 is merged and released