Skip to content

Add namespace to android#66

Open
Hedon-dev wants to merge 1 commit intojuancastillo0:mainfrom
Hedon-dev:main
Open

Add namespace to android#66
Hedon-dev wants to merge 1 commit intojuancastillo0:mainfrom
Hedon-dev:main

Conversation

@Hedon-dev
Copy link

Fixes compile error with gradle 8.

To test this add this to pubspec.yaml:

  wasm_run_flutter: #^0.1.0
    git:
      url: https://github.com/Hedon-dev/wasm_run
      ref: 69a7426
      path: packages/wasm_run_flutter

Fixes compile error with gradle 8.

To test this add this to pubspec.yaml:
```
  wasm_run_flutter: #^0.1.0
    git: https://github.com/Hedon-dev/wasm_run_flutter
```
// to bump the version in their app.
compileSdkVersion 31

namespace 'com.example.wasm_run_flutter'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe this would be better? or the com.example is used in other places?

Suggested change
namespace 'com.example.wasm_run_flutter'
namespace 'com.wasm_run.wasm_run_flutter'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took the same namespace as the group value in Line 3 the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants