Conversation
🦋 Changeset detectedLatest commit: 81d8499 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
there's an array shuffle in jsPsych.randomization - we should use that instead so there's not duplicate instances in the codebase
|
add flexible button positioning for main trials |
…ch-timelines into pr/lakshmanvishnu/69
packages/stroop-task/src/index.ts
Outdated
| } | ||
|
|
||
| // Add practice debrief | ||
| timeline.push(createPracticeDebrief()); |
There was a problem hiding this comment.
bug: if practice_trials = 0, there is still shown a practice complete! screen after instructions.
to fix, just wrap with if (practice_trials > 0) { timeline.push(createPracticeDebrief());
packages/stroop-task/src/index.ts
Outdated
|
|
||
| // Add createCelcomeAndInstruction function | ||
| if (show_welcome_and_instructions) { | ||
| timeline.push(createWelcomeAndInstructions(choice_of_colors)); |
There was a problem hiding this comment.
change to createInstructions() per standardization
There was a problem hiding this comment.
make sure to change in docs too lol
|
remaining issue:
|
3 participants
Opened a new branch of my forked repo which only has the stroop task timeline.