Fix/community links new tab#2185
Fix/community links new tab#2185Siddhartha20242 wants to merge 3 commits intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
===========================================
- Coverage 100.00% 99.53% -0.47%
===========================================
Files 30 30
Lines 633 651 +18
Branches 196 201 +5
===========================================
+ Hits 633 648 +15
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Utkarsh-123github
left a comment
There was a problem hiding this comment.
Hi @Siddhartha20242 ,
why have you made changes in DocsHelp.tsx and DocsHelp.cy.tsx ?
I don't think they are relevant with the issue.
|
Hi, @Utkarsh-123github , I am so sorry that i forgot to make a seperate one for this and committed on the same one I will make sure to change this by today midnight:) |
9e65035 to
4e3ca17
Compare
|
Hi, @Utkarsh-123github , I've cleaned up the PR to only include the community links changes. The codecov check is failing because this change doesn't have test covarage. Could I require the test or if the requirement can be waived for this small UI change? Thanks you so much:) |
Utkarsh-123github
left a comment
There was a problem hiding this comment.
Hi @Siddhartha20242 , still your PR has irrelevant changes. I am closing this PR and please raise a separate PR on a separate branch that has code changes specifically for this issue.
Thanks!
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
This PR updates the Community Section to ensure a better user experience by opening external links (Slack, Discussions, Roadmap, and Blog) in a new browser tab using target='_blank'.
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.