Fix: detect duplicate languages in tooling data#1494
Closed
Vishv04 wants to merge 2 commits intojson-schema-org:mainfrom
Closed
Fix: detect duplicate languages in tooling data#1494Vishv04 wants to merge 2 commits intojson-schema-org:mainfrom
Vishv04 wants to merge 2 commits intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @benjagm @jdesrosiers @DhairyaMajmudar, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature - Adds case-insensitive unique validation for language entries
Bug fix - remove two entries of same name such as 'JavaScript' and 'Javascript'
Issue Number:
Screenshots/videos:

Forcefully made mistakes in the name of language,
Validator finds the mistake,

If relevant, did you update the documentation?
Summary
This PR introduces case-insensitive unique validation for language entries in the tooling data to solve several existing problems:
My solution:
Implements a custom AJV keyword
caseInsensitiveUniquethat:For Tool Maintainers:
Does this PR introduce a breaking change?