Open
Conversation
Author
|
@michaelmior can pls review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Screen.Recording.2026-02-09.231705.mp4
If relevant, did you update the documentation?
No
Summary
This PR fixes a user experience issue where clicking the social media links in the footer (GitHub, Slack, X, YouTube, LinkedIn) would navigate the user away from the current page.
I have updated the
CompanyLogoscomponent inCommunityLinks.tsxto includetarget="_blank"andrel="noopener noreferrer". This ensures that all external links open in a new tab securely, allowing users to stay on the "Tour of JSON Schema" site while viewing the community pages.Does this PR introduce a breaking change?
No