Add ref instead all of for additionalProperties lesson#190
Open
Girishbari wants to merge 2 commits intojson-schema-org:mainfrom
Open
Add ref instead all of for additionalProperties lesson#190Girishbari wants to merge 2 commits intojson-schema-org:mainfrom
Girishbari wants to merge 2 commits intojson-schema-org:mainfrom
Conversation
jdesrosiers
requested changes
Nov 7, 2025
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Looks good. I just had a few editorial suggestions.
...ent/07-Miscellaneous/01-Extending-Closed-Schemas-with-unevaluatedProperties/instructions.mdx
Outdated
Show resolved
Hide resolved
...ent/07-Miscellaneous/01-Extending-Closed-Schemas-with-unevaluatedProperties/instructions.mdx
Outdated
Show resolved
Hide resolved
...ent/07-Miscellaneous/01-Extending-Closed-Schemas-with-unevaluatedProperties/instructions.mdx
Outdated
Show resolved
Hide resolved
jdesrosiers
approved these changes
Nov 10, 2025
JeelRajodiya
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring Chapter 7, refactored the code to use $ref instead $allOf for explanation
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
NO