Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test repo, it's come up a couple of times recently that we have some tests that aren't really testing the implementation, they're tests for the meta-schema. Those don't really belong in that test suite, but we really should have tests for the meta-schema.
This adds a framework to allow us to add tests for the meta-schema. It uses the
@hyperjump-json-schema-coveragepackage I created recently to produce test coverage results. The coverage is very low for now. I only added a few tests covering enough to replace what's in the test suite and a little more.This depends on #1691, so I'm creating this as draft until that's merged. But, otherwise it's fully functional and ready to add a bunch more tests.