You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the patch! Unfortunately, it's formatted incorrectly, so we can't
accept it as-is. I can offer you some help to fix it, though.
You'll want to start by making sure you have checked out the latest version of
the dev branch. Be sure that there are no additional commits "on top" of that
(use git log to check) and that there are no new "unstaged" local changes
(use git status to check).
The tricky part here is that we need to deploy this file to the root of the
site's public file hierarchy, but the current build system isn't really set up
for such an operation. If you place the file in the res/ directory, I would
accept a quick-and-dirty alteration to the project Makefile that copied it
into place at deploy time.
Finally, your pull request should target the dev branch. We'll take care of
updating the master branch the next time we deploy the site.
It's a bit convoluted, to be sure. Does my explanation make sense to you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch for a favicon.