fix(ensureSymlink): resolve relative srcpath correctly when symlink exists

[abhu85]

Summary

Fixes #1038

When ensureSymlink is called with a relative srcpath and the destination symlink already exists, the code was incorrectly resolving the srcpath relative to cwd instead of relative to the dstpath directory.

This caused ENOENT errors when calling ensureSymlink a second time with the same relative path:

// First call works
await ensureSymlink('../target', './link-dir/link', 'dir')

// Second call fails with ENOENT (should succeed)
await ensureSymlink('../target', './link-dir/link', 'dir')

Root Cause

In symlink.js lines 22-28 (async) and 48-52 (sync), when checking if an existing symlink already points to the correct target, fs.stat(srcpath) was called directly. For relative paths, this evaluates from cwd, not from the symlink's directory.

Fix

When srcpath is relative, first try to resolve it relative to dstpath's directory (standard symlink behavior), falling back to cwd if that doesn't exist. This mirrors the logic already used in symlinkPaths().

Changes

• lib/ensure/symlink.js: Fix relative path resolution in both createSymlink and createSymlinkSync
• lib/ensure/__tests__/symlink.test.js: Add regression tests for issue createSymlink fails when ensuring a symbolic link with a relative path if the link already exists #1038

Test Plan

• All existing 720 tests pass
• Added regression tests that reproduce the exact scenario from createSymlink fails when ensuring a symbolic link with a relative path if the link already exists #1038
• Tests verify both async and sync versions

🤖 Generated with Claude Code

[RyanZim]

Verified added tests as failing before changes.

LGTM

[RyanZim]

Probably won't get this released until next week, though.

[RyanZim]

Released in [email protected] 🎉