Use floats rather than ints when computing percentA() and percentB()#16
Closed
erikmd wants to merge 1 commit intojplag:masterfrom
Closed
Use floats rather than ints when computing percentA() and percentB()#16erikmd wants to merge 1 commit intojplag:masterfrom
erikmd wants to merge 1 commit intojplag:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I recently noticed the following detail in the generated files
results/match*.html: the two percentages that appear in the top right-hand side are always truncated to the nearest integer, so that the percentage in the top left-hand side (average similarity) does not seem to correspond to the average.Here is a screenshot that shows the issue.
This seems to be related to the functions
percentA()andpercentB()injplag/AllMatches.javathat should probably compute using floats rather than ints.
Here is another screenshot that shows the same example, if one applies the enclosed patch.
Kind regards.