Fixed bug with string parsing in C/C++#11
Merged
lama0206 merged 1 commit intojplag:masterfrom Oct 27, 2015
Merged
Conversation
There are 2 bugs fixed here: 1. The tokenizer did not recognize characters in the \xHH format. For example, '\x10' 2. The tokenizer interpreted '\0x10' as a proper character, which should actually be interpreted as '\0', 'x', '1', '0' (4 characters), which would not be valid if written as '\0x10'.
Contributor
Author
|
Also, it looks like a character string like |
Contributor
|
Yes. Because JPlag does not compile the program, the values are not important. |
lama0206
added a commit
that referenced
this pull request
Oct 27, 2015
Fixed bug with string parsing in C/C++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 2 bugs fixed here:
example, '\x10'
actually be interpreted as '\0', 'x', '1', '0' (4 characters), which
would not be valid if written as '\0x10'.
Here is some sample input for testing: (save as file.c)
'\x30'With the bugged version, I would get error messages similar to: