Skip to content

Pass the DOM element in onChange#91

Open
McPo wants to merge 1 commit intojoshwnj:masterfrom
McPo:patch-1
Open

Pass the DOM element in onChange#91
McPo wants to merge 1 commit intojoshwnj:masterfrom
McPo:patch-1

Conversation

@McPo
Copy link
Copy Markdown

@McPo McPo commented Sep 5, 2017

Pass the DOM element in onChange. Allows the ability to set data attributes and access them in onChange. Useful for lists. Could pass this instead, and/or remove visibilityRect and instead just pass the element, as visibilityRect is easily accessed from the element.

Need to update documentation as well.

Any thoughts?

Pass the DOM element in onChange. Allows the ability to set data attributes and access them in onChange. Useful for lists. Could pass `this` instead, and/or remove visibilityRect and instead just pass the element, as visibilityRect is easily accessed from the element.
@imakou
Copy link
Copy Markdown

imakou commented Oct 16, 2017

Has the feature migrated into the current ver?

@zthornto
Copy link
Copy Markdown

zthornto commented Jan 8, 2019

+1 for this, would be very handy at times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants