Add Prettier, use Husky and lint-staged to auto-commit prettification#11
Open
joshwcomeau wants to merge 1 commit intomainfrom
Open
Add Prettier, use Husky and lint-staged to auto-commit prettification#11joshwcomeau wants to merge 1 commit intomainfrom
joshwcomeau wants to merge 1 commit intomainfrom
Conversation
joshwcomeau
commented
Sep 30, 2017
| }, | ||
| "devDependencies": { | ||
| "husky": "0.14.3", | ||
| "lint-staged": "4.2.3" |
Owner
Author
There was a problem hiding this comment.
I re-ordered some stuff here, because I like for the dependencies to be near the top.
|
So is this usefull utility package or a playground for testify cool tricks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yay Prettier support! No more debates about code convention :D
As suggested by @morajabi, I used Husky and lint-staged to auto-run Prettier on files before committing. As such, a buncha stuff was "prettified".
@morajabi you'll likely hit a bunch of merge conflicts if this gets merged in before your two PRs. I didn't actually change any of the code, though, so you can take your changes over these for everything. Prettier will re-run when you commit so there's no problem :)
Closes #10