Set parameters when using JWT.decode#64
Merged
jonasroussel merged 3 commits intojonasroussel:mainfrom Feb 3, 2025
JHubi1:main
Merged
Set parameters when using JWT.decode#64jonasroussel merged 3 commits intojonasroussel:mainfrom JHubi1:main
jonasroussel merged 3 commits intojonasroussel:mainfrom
JHubi1:main
Conversation
Set audience, issuer, subject and jwtId when using the JWT.decode function
Owner
|
You are right, I just used you PR to make some refacto to the original code, merge the PR that I created on your fork https://github.com/JHubi1/dart_jsonwebtoken/pull/1 and I can push and publish this one |
refactor: simplify decode method
Contributor
Author
|
Merged it |
jonasroussel
approved these changes
Feb 3, 2025
Owner
|
Added in the last version: https://pub.dev/packages/dart_jsonwebtoken/versions/2.17.0 |
Contributor
Author
|
Thank you very much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the
JWT.decodemethod quite often. I believe it is less resource intense (idk), and easier to implement, because you don't have to set all the check parameters.One thing that's always getting on my nerves is that the function doesn't set the necessary attributes of the JWT object, which makes it harder to work with (arguably not much harder but harder nonetheless).
I'm not sure whether this is a brilliant idea or not. As far as I can tell, nothing should break, but there were no tests and I didn't want to write my own, so I couldn't really test. I added documentation though that lets devs know to use this values with caution as they are not checked.