feat(init): Setup chrome service on docker-compose - #408
Merged
Conversation
loic425
commented
May 28, 2026
| * Insert the Chrome service before the "volumes:" section if it exists. | ||
| * Otherwise, append it to the end of the file. | ||
| */ | ||
| if (preg_match('/^volumes:/m', $content, $matches, PREG_OFFSET_CAPTURE)) { |
Contributor
Author
There was a problem hiding this comment.
It has been done by ChatGPT, so it needs to be checked...
Contributor
Author
There was a problem hiding this comment.
Ok, I've challenged chatGPT to explain this line and the regex option and this is legit 👍
Member
There was a problem hiding this comment.
I meant, have you really tested it? I underdstand the code, but it does not mean it's work well :)
Contributor
Author
There was a problem hiding this comment.
I meant, have you really tested it? I underdstand the code, but it does not mean it's work well :)
Yes I've tried it and run it twice to check and everything is ok 👍
loic425
force-pushed
the
add-chrome-on-init
branch
from
May 28, 2026 10:02
e02a0ae to
3fb42c7
Compare
loic425
commented
May 28, 2026
loic425
force-pushed
the
add-chrome-on-init
branch
from
May 28, 2026 10:07
3fb42c7 to
c36e187
Compare
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.