when no worker is defined, do not stop the complete stack - #398
Merged
Conversation
pyrech
reviewed
May 20, 2026
lyrixx
reviewed
May 27, 2026
lyrixx
left a comment
lyrixx
left a comment
Member
There was a problem hiding this comment.
Like it 👍🏼 Thanks.
I wait for the pyrech's comments to be fixed, then merge it
lyrixx
force-pushed
the
fix/stop-workers-when-no-worker
branch
2 times, most recently
from
May 29, 2026 12:20
f337efd to
7646590
Compare
lyrixx
approved these changes
May 29, 2026
Member
There was a problem hiding this comment.
@xavierlacot I finished the PR.
PHPStan is ko, but not related. I'll pass another PR before this one
lyrixx
force-pushed
the
fix/stop-workers-when-no-worker
branch
from
May 29, 2026 12:48
7646590 to
955e8b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no worker is defined in the "worker" profile, running
castor docker:worker:stopstops the complete stack. This PR instead displays an error message in such a case.