Max Updates: adding some new fields (Last commit, Last public commit, Top languages, Total Stars), design and add favicon, Rename python scripts, Remove data injector and load data in runtime by ajax from json, Auto minifier for output html file, etc #110#111
Max Updates: adding some new fields (Last commit, Last public commit, Top languages, Total Stars), design and add favicon, Rename python scripts, Remove data injector and load data in runtime by ajax from json, Auto minifier for output html file, etc #110#111BaseMax merged 29 commits intojohn-bampton:mainfrom
Conversation
…-bampton.github.io into max-updates-improve
Summary of ChangesHello @BaseMax, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's data handling and presentation layer. It moves from a server-rendered approach, where user data was embedded directly into HTML, to a more modern client-side rendering model. This change, coupled with the introduction of new, richer user data fields and advanced filtering capabilities, enhances the user experience by providing more dynamic and interactive ways to explore GitHub profiles. The build process has also been streamlined with clearer script names and automatic HTML minification. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring of the application's data loading and rendering mechanism, moving from client-side DOM parsing to fetching user data from a users.json file. Key changes include updating the fetch.py script to gather more comprehensive user details such as total stars, top languages, last repository activity, and last public commit dates, utilizing both GitHub's GraphQL and REST APIs. The render.py script was updated to generate a static HTML shell and export the processed user data into docs/users.json, which is now loaded asynchronously by script.js. The script.js file was heavily modified to dynamically build user cards from this JSON data, rather than parsing existing HTML, and new filtering and sorting options were added for total stars, programming languages, and activity dates. Corresponding UI updates were made in layouts/layout.html (which now consolidates the previous header.html, footer.html, and card.html templates), docs/styles.css for new filter inputs and card elements, and docs/manifest.json and docs/service-worker.js for updated PWA assets. Review comments highlighted the need to use innerHTML instead of textContent for rendering HTML in script.js, corrected a conditional check for last_public_commit_at, and suggested removing dead code (parseUserCard, extractLocation, extractStats) and simplifying a redundant variable assignment in fetch.py.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…-bampton.github.io into max-updates-improve
…it by running python generate each time
…sers daily once not more but force updating docs/index.html after any commits
|
cc #85 |
This update introduces several enhancements and improvements to the project:
These changes streamline the workflow, enhance user experience, and simplify data management.