Merged many good pull requests for you#409
Open
trishume wants to merge 10 commits intojigish:masterfrom
Open
Conversation
Including a description for how to turn on the Accessibility API for OS X 10.9 Mavericks.
Found with XCode 5's static analyis tool
This can be useful to distinguish between apps like Chrome and Chrome
Canary (which both report their name as "Google Chrome" but have bundle
identifiers `com.google.Chrome` and `com.google.Chrome.canary`
respectively).
This can be used in a `.slate.js` to do things like the following,
which is a layout that pushes Canary windows to the left half of the
screen and normal Chrome windows to the right half:
slate.layout('my-layout', {
'Google Chrome': {
operations: [function(window) {
var app = window.app();
if (app.bundleIdentifier() === 'com.google.Chrome.canary') {
// code to push window left
} else {
// code to push window right
}
}],
repeat: true,
},
});
|
@trishume Thanks a lot! |
|
👍 |
|
@trishume It may also be helpful to explain which PRs you did not merge and why not. |
Contributor
Author
|
At this point I forget. One criteria was I only merged PRs that were complete and ready to merge. In the case of duplicates I only merged whichever one looked nicer. I also only merged PRs which I believed would be non-controversial. If something looked like some people might disagree with it being merged (or somebody had already voiced concerns) then I didn't add it. |
p0deje
added a commit
to p0deje/dotfiles
that referenced
this pull request
Jul 23, 2014
using version from jigish/slate#409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an amalgamation of the merging of many of the good pull requests that have been submitted but not merged. I've compiled and tested them and they all work together.
Anyone who wants an app package with all these changes can download one here (not signed sorry):
http://thume.net/downloads/Slate.zip
@jigish if you don't want to look at individual PRs you can just merge this one.
Creators of PRs in this one: @josh- @napcae @jpsim @mattr- @wincent @georg