Conversation
Applications shouldn't be expecting an `Attributes` as a result from running Redis commands.
Storing attributes on the connection doesn't seem useful since the Redis server might not send them to all connections and we have no way to guarantee that a `Client` would yield the same `Connection` twice in a row. This way, all attributes on all connections on a given `Client` can be guaranteed to funnel through a single block and it's up to the caller to determine what to do with it. Open question: should we also yield the connection to the client in that block? How does that work for `Cluster` and `ReplicationClient`?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68