Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions git_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ func TestGitAuditViolationsWithIgnoreRule(t *testing.T) {
}

func TestGitAuditJasViolationsProjectKeySimpleJson(t *testing.T) {

xrayVersion, xscVersion, testCleanUp := integration.InitGitTest(t, services.MinXrayVersionGitRepoKey)
defer testCleanUp()

Expand All @@ -220,10 +221,12 @@ func TestGitAuditJasViolationsProjectKeySimpleJson(t *testing.T) {
// Run the audit command with git repo and verify violations are reported to the platform.
createTestProjectRunGitAuditAndValidate(t,
filepath.Join(filepath.FromSlash(securityTests.GetTestResourcesPath()), "git", "projects", "issues"),
gitAuditCommandTestParams{auditCommandTestParams: auditCommandTestParams{Format: format.SimpleJson, ProjectKey: *securityTests.JfrogTestProjectKey}},
gitAuditCommandTestParams{auditCommandTestParams: auditCommandTestParams{Format: format.SimpleJson, ProjectKey: *securityTests.JfrogTestProjectKey, WithVuln: true}},
xrayVersion, xscVersion, policy.NewFailBuildError().Error(),
validations.ValidationParams{
Total: &validations.TotalCount{Violations: 12},
Total: &validations.TotalCount{Vulnerabilities: 12, Violations: 12},
// Validate we have vulnerabilities for each scan type (to make sure if violations are issue when fail or not related and issue from other places before)
Vulnerabilities: &validations.VulnerabilityCount{ValidateScan: &validations.ScanCount{Sca: 1, Sast: 1, Secrets: 1}},
// Check that we have at least one violation for each scan type. (IAC is not supported yet)
Violations: &validations.ViolationCount{ValidateScan: &validations.ScanCount{Sca: 1, Sast: 1, Secrets: 1}},
},
Expand Down
2 changes: 1 addition & 1 deletion jas/analyzermanager.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
const (
ApplicabilityFeatureId = "contextual_analysis"
AnalyzerManagerZipName = "analyzerManager.zip"
defaultAnalyzerManagerVersion = "1.27.0"
defaultAnalyzerManagerVersion = "1.29.0"
analyzerManagerDownloadPath = "xsc-gen-exe-analyzer-manager-local/v1"
analyzerManagerDirName = "analyzerManager"
analyzerManagerExecutableName = "analyzerManager"
Expand Down
5 changes: 5 additions & 0 deletions utils/results/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ func ForEachJasIssue(runs []*sarif.Run, entitledForJas bool, handler ParseJasIss
}
for _, run := range runs {
for _, result := range run.Results {
if result.Kind == "informational" {
// The specified rule was evaluated and produced a purely informational result that does not indicate the presence of a problem
log.Verbose(fmt.Sprintf("Skipping informational result with rule id: %s", sarifutils.GetResultRuleId(result)))
continue
}
severity, err := severityutils.ParseSeverity(result.Level, true)
if err != nil {
return err
Expand Down