Skip to content

Add a PingThread to prevent ws channel getting stuck during initialization - #815

Draft
gbhat618 wants to merge 3 commits into
jenkinsci:masterfrom
gbhat618:ping-thread-on-remoting
Draft

Add a PingThread to prevent ws channel getting stuck during initialization#815
gbhat618 wants to merge 3 commits into
jenkinsci:masterfrom
gbhat618:ping-thread-on-remoting

Conversation

@gbhat618

Copy link
Copy Markdown
Contributor

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jglick

jglick commented Sep 2, 2025

Copy link
Copy Markdown
Member

Why would this be limited to WebSocket transport?

@gbhat618

Copy link
Copy Markdown
Contributor Author

Why would this be limited to WebSocket transport?

I think it would be applicable to TCP too, I only tested for WebSocket, so didn't touch the TCP code. I should try with tcp agents and observe the issue once there too (looks like it is easily observed when 300+ agents all connecting in short duration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants