feat: add linux/riscv64 platform to Debian images#2277
feat: add linux/riscv64 platform to Debian images#2277gounthar wants to merge 4 commits intojenkinsci:masterfrom
Conversation
Add riscv64 to the default (Debian) platform list in the platforms() function. Adoptium provides JDK 21 and 25 binaries for riscv64, and Debian Trixie supports the architecture natively. Debian-only as discussed in jenkinsci#2272 — Alpine, RHEL, and slim variants remain unchanged. Fixes jenkinsci#2272 Signed-off-by: Bruno Verachten <[email protected]>
|
Did you try |
Add riscv64 to architecturesAndCiJioAgentLabels in Jenkinsfile, using QEMU on amd64 agents (same as ppc64le and s390x). Signed-off-by: Bruno Verachten <[email protected]>
|
@lemeurherve Fair point, I missed the Jenkinsfile. Added |
That wasn't my point 😉 I encourage you to actually run |
|
It's been running for a while now... |
Add debian_jdk{21,25}:linux/riscv64 to the expected platforms golden
file to match the updated platforms() function in docker-bake.hcl.
Signed-off-by: Bruno Verachten <[email protected]>
Possible, better to be done before opening a PR. |
|
Yes, but it’s just a draft. You’re right, nonetheless, I opened it before |
|
@lemeurherve Verified locally: |
No reason to exclude riscv64 from slim when full Debian has it. The base image (debian:trixie-slim) supports riscv64. Signed-off-by: Bruno Verachten <[email protected]>
lemeurherve
left a comment
lemeurherve
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks @gounthar!
Requesting changes to avoid merging this PR before the Weekly and LTS security releases of Wednesday. (can't check its publication before)
|
Of course. Thanks a lot for the review! 👍 |
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
Change looks good to me. Ready to merge and release after the security release is complete.
3 participants
Summary
linux/riscv64to the default (Debian) platform list in theplatforms()function ofdocker-bake.hclContext
Adoptium provides JDK 21 and 25 binaries for riscv64, and Debian Trixie supports the architecture natively. The
jdk-download-url.shscript already handles riscv64 viauname -mwithout changes.The Jenkins Docker agents already ship riscv64 images (jenkinsci/docker-agents#1168, released in v3355.v388858a_47b_33-16). This PR completes the set by adding riscv64 to the controller image.
Test plan
docker buildx bake debian --printincludeslinux/riscv64in the platforms listFixes #2272