Allow user to set ffmpeg path via environment variable#8
Open
lesservehicle wants to merge 1 commit into
Open
Conversation
|
Just a note "/usr/bin/ffmpeg" wont work on windows. If it gets remove from $PATH you are not setting it up correctly. As a note if you export PATH in a console it will be temporary in that console window until closed but if you edit the path file /etc/paths it should be permanent. |
Owner
|
Thanks for your contribution. Yes, I think @hesa2020 is right. Maybe you should keep the default path as "ffmpeg" so that it works better on all platforms. @lesservehicle Please change "/usr/bin/ffmpeg" to "ffmpeg". Then I will merge it, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I just ran into an issue on macOS, running this with a Homebrew installed version of ffmpeg. The function as-is assumes that the shell is aware of the location of ffmpeg via $PATH, but depending on how you execute the node, your path may be wiped out. I've seen other nodes use this sort of method as a workaround to that.