feat: support flux model on mlu device.#1138
Open
phantomlei3 wants to merge 7 commits intojd-opensource:mainfrom
Open
feat: support flux model on mlu device.#1138phantomlei3 wants to merge 7 commits intojd-opensource:mainfrom
phantomlei3 wants to merge 7 commits intojd-opensource:mainfrom
Conversation
phantomlei3
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
XuZhang99
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request extends support for CUDA and MLU backends within the DiT model framework by updating preprocessor guards and including necessary headers for Flux pipelines. It also modifies flag validation for the MLU backend to accommodate the 'dit' backend. A critical issue was identified in xllm/xllm.cpp where the model_type variable is shadowed inside an if block, causing it to remain empty in the outer scope and potentially leading to incorrect validation logic.
XuZhang99
changed the title
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
XuZhang99
previously approved these changes
Mar 30, 2026
XuZhang99
reviewed
Apr 2, 2026
XuZhang99
previously approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.