feat: support embedding interface for all generate VLM models.#1136
Open
xanecdotex wants to merge 1 commit intojd-opensource:mainfrom
Open
feat: support embedding interface for all generate VLM models.#1136xanecdotex wants to merge 1 commit intojd-opensource:mainfrom
xanecdotex wants to merge 1 commit intojd-opensource:mainfrom
Conversation
xanecdotex
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the model architecture by removing the specialized EmbeddingVLM interface and integrating the pooler functionality directly into the CausalVLM base class and its implementations. This change simplifies the model hierarchy and registry logic by deleting embedding_vlm.h and removing redundant factory functions. However, a critical issue was identified: several language model implementations, such as Glm4, Oxygen, and Qwen3, are missing the pooler method. Since the updated VLM classes now delegate pooling operations to these underlying models, the missing implementations will result in compilation failures.
xanecdotex
force-pushed
the
dvlp/qwen3vlemb
branch
from
4ccbad0 to
d4ea385
Compare
xanecdotex
force-pushed
the
dvlp/qwen3vlemb
branch
from
d4ea385 to
4448d6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.