feat: support qwen3-omni talker and code2wav.#1070
Open
ethan686 wants to merge 6 commits intojd-opensource:mainfrom
Open
feat: support qwen3-omni talker and code2wav.#1070ethan686 wants to merge 6 commits intojd-opensource:mainfrom
ethan686 wants to merge 6 commits intojd-opensource:mainfrom
Conversation
ethan686
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The code review identified a critical issue in NpuQwen3MoeDecoderLayerImpl::forward where the function continues to return tensor_placeholder_ even after a failed decode layer execution, indicated by a non-zero status code. To prevent the propagation of potentially corrupted data, the reviewer suggested that the function should either return early or throw an exception when st != 0.
XuZhang99
reviewed
Mar 18, 2026
| @@ -0,0 +1,362 @@ | |||
| #pragma once | |||
| @@ -0,0 +1,284 @@ | |||
| /* Copyright 2025 The xLLM Authors. All Rights Reserved. | |||
|
|
||
| void Qwen3MoeDecoderLoader::verify_loaded_weights( | ||
| const std::string& prefix) const { | ||
| VLOG(50) << "start verify"; |
| at_weight_tensors_[IN_MLP_GATEUP_WEIGHT_EXPERT] = | ||
| at_npu::native::npu_format_cast(mlp_gateup_weight, 2).contiguous(); | ||
| VLOG(50) << "gmm weight gateup shape" | ||
| << at_weight_tensors_[IN_MLP_GATEUP_WEIGHT_EXPERT].sizes(); |
|
|
||
| {"mlp_layer_scale.scale", IN_MLP_LAYER_SCALE_SCALE}}; | ||
|
|
||
| static const std::map<int, int> WEIGHT_SHARD = {{IN_QKV_WEIGHT_Q, 0}, |
Collaborator
There was a problem hiding this comment.
why not use std::unordered_map?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.