bugfix: fix decode instance infinite retry allocate.#1045
Open
magicheng0816 wants to merge 1 commit intojd-opensource:mainfrom
Open
bugfix: fix decode instance infinite retry allocate.#1045magicheng0816 wants to merge 1 commit intojd-opensource:mainfrom
magicheng0816 wants to merge 1 commit intojd-opensource:mainfrom
Conversation
magicheng0816
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for a potential infinite retry loop when a decode instance fails to allocate resources. It adds a retry limit for requests that are rejected. The overall logic is sound and effectively addresses the bug. I've provided one suggestion to optimize the locking mechanism in the retry logic to reduce lock contention and improve performance by consolidating two separate lock acquisitions into a single critical section.
XuZhang99
reviewed
Mar 12, 2026
|
|
||
| // Max retries when D returns 404 (e.g. try_allocate failed), avoid infinite | ||
| // retry. | ||
| static constexpr int kAddNewRequestsMaxRetryOnReject = 3; |
Collaborator
There was a problem hiding this comment.
int ==> int32_t or int64_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.