Conversation
|
The tests run well under my environment. I have no idea yet why the CI failed here. (help wanted) |
davidag
left a comment
There was a problem hiding this comment.
Hello @hiiwave, let me give you my opinion on these changes:
- I would try to avoid raising
WatsonErrorincli.py. Just useclick.ClickExceptionwhich is in fact what_watson.WatsonErroris (still) incli.py. See #315 - I'm not sure the check for empty project at the beginning of `Watson.start() is still necessary. Did you try to remove and run the tests?
- Could you add a line in the changelog describing the fix?
I hope it helps!
@jmkerr do you have any clue of why
As far as I have seen, it is common practice here. |
This is completely unrelated to the content of the commit, but possibly related to the time the test was run between 00:00 and 01:00 UTC. I'll take a look at the problem and open another issue. (I'm sorry.) |
@jmkerr thank you for your help! If there's some way we can help you out, just say it! 👍 |
Co-Authored-By: Julien Maupetit <jmaupetit@users.noreply.github.com>
This is to fix #321