Add delete customer functionality in admin panel#131
Open
golukumar2156 wants to merge 1 commit intojaygajera17:master2from
Open
Add delete customer functionality in admin panel#131golukumar2156 wants to merge 1 commit intojaygajera17:master2from
golukumar2156 wants to merge 1 commit intojaygajera17:master2from
Conversation
Author
|
Hi maintainer 👋 |
abdurraffaysyed
left a comment
There was a problem hiding this comment.
Hi @golukumar2156,
Instead of hard deleting the customers, I was thinking of updating their status to inActive. With this approach if the same user comes in later on then instead of adding their details all over again we can simply change their Active status. What do you say?
Author
|
Hi @abdurraffaysyed,
Good point. Soft delete with an inactive status sounds useful. Let’s go
with this approach. I’ll make the changes and update the PR. Thanks!
…On Sat, 17 Jan, 2026, 05:15 Syed Muhammad Abdurraffay, < ***@***.***> wrote:
***@***.**** commented on this pull request.
Hi @golukumar2156 <https://github.com/golukumar2156>,
Instead of hard deleting the customers, I was thinking of updating their
status to inActive. With this approach if the same user comes in later on
then instead of adding their details all over again we can simply change
their Active status. What do you say?
—
Reply to this email directly, view it on GitHub
<#131 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHBNBLXJZZTMGENILRPKKA34HFZ25AVCNFSM6AAAAACRJIRKICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNZTGE3DKMJYHA>
.
You are receiving this because you were mentioned.Message ID:
<jaygajera17/E-commerce-project-springBoot/pull/131/review/3673165188@
github.com>
|
abdurraffaysyed
left a comment
There was a problem hiding this comment.
@golukumar2156
I have raised an issue for the SoftDelete functionality too. You can have a review of that for a better understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing delete functionality for customers in the admin panel.
Changes
Root Cause
The delete option was visible in the UI but no backend/view logic was implemented.
Fixes #129