Vectorize Gathering of Recordings - #805
Open
alexpejovic wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is far from merge-worthy, but I want it to be here just to highlight a better implementation for gathering recordings. The old way of gathering recordings creates massive JIT compile times for networks with many recordings (in the 10s of thousands). When testing flyvis performance, Michael committed f0e95fe which removed gathering recordings by state all-together, massively improving compile times for large networks.
This is just a general solution of Michael's commit. If anyone wants proof that this improves compile times, I can provide it, but in any case I think fixing the unit-testing for the 1.0.0 precludes any more merging. Either that, or I make a PR for the main branch.