Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
One of the UTF7 byte order mark (BOM) variants was redundant; it is an extension of one of the subsequent pattern variants. This does not affect correctness, but it does imply that string-matching work may be duplicated. Remove the longer, superset prefix to remove a comparison when inspecting some UTF7 BOM content. Refs: - Closes #716. - Follow-up to PR #717. - Relates-to commit b579cd6.
jayaddison
force-pushed
the
pr-717-followup/remove-redundant-utf7-bom-substring
branch
from
a095daf to
d0f1a39
Compare
Contributor
Author
|
Thanks again 👍 |
jayaddison
deleted the
pr-717-followup/remove-redundant-utf7-bom-substring
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the UTF7 byte order mark (BOM) variants was redundant; it is an extension of one of the subsequent pattern variants.
This does not affect correctness, but it does imply that string-matching work may be duplicated.
Remove the longer, superset prefix to remove a comparison when inspecting some UTF7 BOM content.
Refs: