fixed off by 1 error, otherwise geoJson Search always goes at least 2 levels deep...#434
Open
SpocWeb wants to merge 1 commit into
Open
fixed off by 1 error, otherwise geoJson Search always goes at least 2 levels deep...#434SpocWeb wants to merge 1 commit into
SpocWeb wants to merge 1 commit into
Conversation
even when only a single / is appended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...even when only a single / is appended.
Pull Request Description
Hi, this PR fixes an off-by-1 error that leads to extremely long loading times (hours),
when you have many geojson Files in deeper nested directories.
Changes Proposed
By reducing the initial Counter to 1 you can limit the depth to just the given Directory.
I have tested it with all my Repos, e.g. this: https://github.com/SpocWiki/Europe-Germany
Related Issues
Breaking change:
Of course this means that everyone needs to append a single '/' to get the results as before.
Fixes #Issue_Number
Checklist
Screenshots (if applicable)
Additional Notes
none