Open
Conversation
Fixes jashkenas#5428 This fix is simple enough but it causes a substantial change in behavior for Heregexes. `#` inside of a character class shouldn't be considered a comment. By treating `#` without whitespace in front as non-comments we could have slight compatability with Python. There are other places in the CoffeeScript source where people avoided escaping the `#` by keeping it next to non-whitespace characters even outside of a character class. This is different than how Python does it and is probably a bug but maybe it is too late with the de facto CoffeeScript2 behavior. I'm not sure if this should be merged in since it changes the behavior quite a lot. Maybe another one for the CoffeeScript3/Civet bucket. Refs --- Python Docs: https://docs.python.org/3/library/re.html#re.X
STRd6
force-pushed
the
heregex-comment
branch
from
a4b6e8a to
98a2331
Compare
Contributor
Author
|
GitHub auto-closed when I rebased so re-opening. |
Contributor
Author
|
The interpolation test that was changed is interesting... It's inserting a string containing a single backslash into the RegExp ahead of an escaped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5428
This fix is simple enough but it causes a substantial change in behavior for Heregexes.
#inside of a character class shouldn't be considered a comment. By treating#without whitespace in front as non-comments we could have slight compatability with Python.There are other places in the CoffeeScript source where people avoided escaping the
#by keeping it next to non-whitespace characters even outside of a character class. This is different than how Python does it and is probably a bug but maybe it is too late with the de facto CoffeeScript2 behavior.I'm not sure if this should be merged in since it changes the behavior quite a lot. Maybe another one for the CoffeeScript3/Civet bucket.
Refs
Python Docs: https://docs.python.org/3/library/re.html#re.X