Skip to content

[EMH] Activate automatic OBIS discovery - #174

Open
jannickfahlbusch wants to merge 1 commit into
mainfrom
emh/dynamicOBISDiscovery
Open

[EMH] Activate automatic OBIS discovery#174
jannickfahlbusch wants to merge 1 commit into
mainfrom
emh/dynamicOBISDiscovery

Conversation

@jannickfahlbusch

@jannickfahlbusch jannickfahlbusch commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

New Features:

  • Enable automatic OBIS discovery for EMH gateways.

@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enable dynamic OBIS discovery by default for the EMH gateway implementation.

File-Level Changes

Change Details Files
Enable automatic/dynamic OBIS discovery for EMH gateway instances.
  • Initialize a new instance attribute to control dynamic OBIS discovery behavior.
  • Set the dynamic OBIS discovery flag to True during EMH gateway construction so it is enabled by default.
custom_components/ppc_smgw/gateways/emh/emh.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jannickfahlbusch

Copy link
Copy Markdown
Owner Author

/build-alpha

@github-actions

Copy link
Copy Markdown
Contributor

Alpha release v0.0.25-alpha1511 published!

Install via HACS (enable beta versions): v0.0.25-alpha1511

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Hard-coding dynamic_obis_discovery_enabled = True may not be desirable for all deployments; consider making this configurable via integration options or constructor parameters.
  • If other gateway implementations use a similar flag, verify consistency across them so behavior is predictable and not EMH-specific without intention.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Hard-coding `dynamic_obis_discovery_enabled = True` may not be desirable for all deployments; consider making this configurable via integration options or constructor parameters.
- If other gateway implementations use a similar flag, verify consistency across them so behavior is predictable and not EMH-specific without intention.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jannickfahlbusch jannickfahlbusch linked an issue Aug 20, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for SMGW from EMH Metering

1 participant