[EMH] Activate automatic OBIS discovery - #174
Open
jannickfahlbusch wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnable dynamic OBIS discovery by default for the EMH gateway implementation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Owner
Author
|
/build-alpha |
Contributor
|
Alpha release Install via HACS (enable beta versions): v0.0.25-alpha1511 |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Hard-coding
dynamic_obis_discovery_enabled = Truemay not be desirable for all deployments; consider making this configurable via integration options or constructor parameters. - If other gateway implementations use a similar flag, verify consistency across them so behavior is predictable and not EMH-specific without intention.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Hard-coding `dynamic_obis_discovery_enabled = True` may not be desirable for all deployments; consider making this configurable via integration options or constructor parameters.
- If other gateway implementations use a similar flag, verify consistency across them so behavior is predictable and not EMH-specific without intention.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
New Features: