Reworked tagged literals#650
Closed
shantanu-sardesai wants to merge 16 commits intojank-lang:mainfrom
Closed
Conversation
Contributor
Author
|
Still thinking on how to make reader suppression work with jank. |
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
7 times, most recently
from
6ab6a25 to
cd502b4
Compare
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
6 times, most recently
from
137c1ed to
47654cf
Compare
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
2 times, most recently
from
8f0fba3 to
b53a83d
Compare
I also took the oportunity to convert our jank tagged literal functions to obey the same contracts as other tagged data-readers.
The Clojure reader relaxes tagged literal syntax rules when dealing with a form in an unsupported reader conditional. This is done because an implementation of Clojure on a specific platform can't make any assumptions on what tagged literals other platform implementations will support.
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
from
b53a83d to
b3a26b1
Compare
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
from
b3a26b1 to
9806647
Compare
|
|
||
| return jtl::ok(); | ||
| }); | ||
| if(item->is_err()) |
Contributor
Author
There was a problem hiding this comment.
One behaviour difference here, from the existing implementation, is that the parser will report all the errors (mainly the duplicate keys error) for the key before any errors for the value will be reported.
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
4 times, most recently
from
acc76a9 to
a3fd437
Compare
shantanu-sardesai
force-pushed
the
issues/639-tagged-literals
branch
from
a3fd437 to
284a079
Compare
Merged
3 tasks
Contributor
Author
|
As per our discussion, I'm closing this one in favour of this implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some fixes in this PR to the parser besides the changes required for reworking the tagged reader parser.
map,set, etc.) can cause a stack overflow.Resolves #639.