build(eclair): add noble-based image for Eclair nodes#1363
Open
Jem256 wants to merge 1 commit intojamaljsr:masterfrom
Open
build(eclair): add noble-based image for Eclair nodes#1363Jem256 wants to merge 1 commit intojamaljsr:masterfrom
Jem256 wants to merge 1 commit intojamaljsr:masterfrom
Conversation
Greptile SummaryThis PR fixes Eclair node crashes when opening channels by migrating the Docker images from Alpine Linux to Ubuntu Noble (Debian-based). The changes comprehensively update all Alpine-specific tooling to Debian equivalents across both the Dockerfile and entrypoint script. Key changes:
All changes are consistent and complete. The migration addresses the root cause of the channel opening crashes while maintaining compatibility with Polar's volume permission handling across different host platforms. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| docker/eclair/Dockerfile | Migrates from Alpine to Noble-based eclipse-temurin images, updates package manager commands from apk to apt-get, replaces su-exec with gosu, and improves mkdir commands with -p flag |
| docker/eclair/docker-entrypoint.sh | Updates user/group creation from Alpine syntax (adduser/addgroup) to Debian syntax (useradd/groupadd) and replaces su-exec with gosu |
Last reviewed commit: 3542ab3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 211 211
Lines 7014 7014
Branches 1398 1348 -50
=========================================
Hits 7014 7014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1212
Description
This PR fixes a bug where eclair crashes when trying to open channels with the v0.12.0 & v13.0.1 docker image. This is with eclair <-> eclair and eclair<->lnd channels. Uses;
Steps to Test
Screenshots