Skip to content

build(eclair): add noble-based image for Eclair nodes#1363

Open
Jem256 wants to merge 1 commit intojamaljsr:masterfrom
Jem256:eclair-bug
Open

build(eclair): add noble-based image for Eclair nodes#1363
Jem256 wants to merge 1 commit intojamaljsr:masterfrom
Jem256:eclair-bug

Conversation

@Jem256
Copy link
Copy Markdown
Contributor

@Jem256 Jem256 commented Mar 1, 2026

Closes #1212

Description

This PR fixes a bug where eclair crashes when trying to open channels with the v0.12.0 & v13.0.1 docker image. This is with eclair <-> eclair and eclair<->lnd channels. Uses;

  • eclipse-temurin:25.0.2_10-jdk-noble as build image
  • eclipse-temurin:25.0.2_10-jre-noble as runtime image

Steps to Test

  1. Create nextwork eclair and lnd nodes
  2. Create eclair <-> eclair and eclair<->lnd channels

Screenshots

Screenshot from 2026-03-01 21-02-46

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Mar 1, 2026

Greptile Summary

This PR fixes Eclair node crashes when opening channels by migrating the Docker images from Alpine Linux to Ubuntu Noble (Debian-based). The changes comprehensively update all Alpine-specific tooling to Debian equivalents across both the Dockerfile and entrypoint script.

Key changes:

  • Base images updated from eclipse-temurin:25.0.1_8-jdk-alpine to eclipse-temurin:25.0.2_10-jdk-noble (build) and corresponding JRE images (runtime)
  • Package management: apkapt-get with proper cleanup of /var/lib/apt/lists/* for smaller image size
  • User management: Alpine's adduser/addgroup → Debian's useradd/groupadd with appropriate flags
  • Privilege dropping: su-execgosu for running as non-root user
  • Added -p flags to mkdir commands for better idempotency

All changes are consistent and complete. The migration addresses the root cause of the channel opening crashes while maintaining compatibility with Polar's volume permission handling across different host platforms.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The migration from Alpine to Noble is complete, consistent, and addresses a specific bug. All Alpine-specific commands have been correctly updated to their Debian equivalents. The changes are isolated to Eclair Docker infrastructure and don't modify application logic. Image cleanup practices follow best practices.
  • No files require special attention

Important Files Changed

Filename Overview
docker/eclair/Dockerfile Migrates from Alpine to Noble-based eclipse-temurin images, updates package manager commands from apk to apt-get, replaces su-exec with gosu, and improves mkdir commands with -p flag
docker/eclair/docker-entrypoint.sh Updates user/group creation from Alpine syntax (adduser/addgroup) to Debian syntax (useradd/groupadd) and replaces su-exec with gosu

Last reviewed commit: 3542ab3

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (711755f) to head (3542ab3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          211       211           
  Lines         7014      7014           
  Branches      1398      1348   -50     
=========================================
  Hits          7014      7014           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@erickcestari erickcestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! It fixed for me, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: eclair v0.12.0 docker image: eclair crashes when trying to open channels

2 participants