Allow tapd REST endpoint to be called from within the Docker network

[jcbrand]

Description

I've been setting up additional services inside the Polar Docker network and sometimes they need to call the nodes' API.

The certificate generated for tapd has an altname configured for the Docker host's IP address, but not for the docker container itself.

This PR fixes that.

Steps to Test

1. Create a tapd node in Polar
2. Make an HTTP REST call from another Docker container
3. With this PR it should work, without it you should get a TLS certificate error.

@jamaljsr If you agree with this change, we should probably do the same for LND as well (and not just LITD).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a94762d) to head (d45bbed).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          160       160           
  Lines         6002      6002           
  Branches      1218      1219    +1     
=========================================
  Hits          6002      6002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jamaljsr]

I'm a bit confused on this PR. I was able to make a request to the tapd REST API without any issues using the container name polar-n1-bob-tap from another container on the network. I used alice-tap to make the request.

Also, your PR description mentions tapd but the code change only impacts litd nodes. Can you elaborate more on the specific issue you are facing? What hostname:port you are having trouble connecting to?

[jamaljsr]

@jcbrand Are you still going to work on this PR?

[jcbrand]

Hi @jamaljsr, I was on holiday and am only back at work this week.

I'm a bit swamped at the moment and can't look into this right now. Can you please keep this open for a few weeks then I'll try to investigate again and get back to you?

[jamaljsr]

Ok np. Thanks for the update.