chore: gitignore AI session artefacts - #194
Merged
Merged
Conversation
Add .claude/, .planning/, .company/, COMPANY.md, and CLAUDE.md to .gitignore so future contributor sessions cannot accidentally commit local-only AI tracking artefacts. No content change today; future-proofing only. asqav cloud intentionally tracks CLAUDE.md as contributor rules; this repo does not, so CLAUDE.md is also gitignored here. comment hygiene clean
This was referenced May 18, 2026
q-qp-p
pushed a commit
to q-qp-p/asqav-sdk
that referenced
this pull request
Aug 4, 2026
…#135) * fix(python): align DORA incident_class vocabulary with JC 2024-33 Annex II Adds DORA_INCIDENT_CLASS_NAMESPACE (the canonical six values from Annex II field 3.23 of JC 2024-33, published 17 July 2024) and the legacy 12-value alias map LEGACY_DORA_ALIASES that mirrors the cloud's backward-compat dict from PR jagmarques#194. The sign path validates incident_class client-side: any token outside both sets raises ValueError before the HTTP roundtrip, matching how RECEIPT_TYPE_NAMESPACE already works. Existing test fixtures used a placeholder ICT-INC-001 that the cloud's strict validator now rejects. Replaced with cybersecurity_related so the SDK contract tests stay green against the corrected cloud schema. CLI --incident-class help text and python/docs/CLI.md updated to spell out the six valid values rather than the imprecise "DORA ITS vocabulary" paraphrase. Six new tests cover the canonical namespace shape, alias-into-canonical invariant, parametrised acceptance of all six values, legacy-alias forwarding, and the pre-HTTP rejection of unknown tokens. * docs(sweep): align DORA citations with corrected -02 spec - typescript/README.md: replace "DORA ITS code" gloss on the `incidentClass` field with the canonical 6-value Annex II field 3.23 list (JC 2024-33, 17 July 2024) and a note pointing legacy receipts at LEGACY_DORA_ALIASES. - CHANGELOG.md: add an Unreleased docs entry summarizing the sweep so the next published note carries the citation fix.
q-qp-p
pushed a commit
to q-qp-p/asqav-sdk
that referenced
this pull request
Aug 4, 2026
…TS) (jagmarques#136) * fix(python): align DORA incident_class vocabulary with JC 2024-33 Annex II Adds DORA_INCIDENT_CLASS_NAMESPACE (the canonical six values from Annex II field 3.23 of JC 2024-33, published 17 July 2024) and the legacy 12-value alias map LEGACY_DORA_ALIASES that mirrors the cloud's backward-compat dict from PR jagmarques#194. The sign path validates incident_class client-side: any token outside both sets raises ValueError before the HTTP roundtrip, matching how RECEIPT_TYPE_NAMESPACE already works. Existing test fixtures used a placeholder ICT-INC-001 that the cloud's strict validator now rejects. Replaced with cybersecurity_related so the SDK contract tests stay green against the corrected cloud schema. CLI --incident-class help text and python/docs/CLI.md updated to spell out the six valid values rather than the imprecise "DORA ITS vocabulary" paraphrase. Six new tests cover the canonical namespace shape, alias-into-canonical invariant, parametrised acceptance of all six values, legacy-alias forwarding, and the pre-HTTP rejection of unknown tokens. * fix(typescript): align DORA incident_class vocabulary with JC 2024-33 Annex II Adds DORA_INCIDENT_CLASS_NAMESPACE (the canonical six values from Annex II field 3.23 of JC 2024-33, published 17 July 2024) plus the DoraIncidentClass union type, and the legacy 12-value alias map LEGACY_DORA_ALIASES that mirrors the cloud's backward-compat dict from PR jagmarques#194. The sign path validates incidentClass client-side: any token outside both sets throws AsqavError before the HTTP roundtrip, matching how RECEIPT_TYPE_NAMESPACE already works. Existing test fixtures used a placeholder ICT-INC-001 that the cloud's strict validator now rejects. Replaced with cybersecurity_related so the SDK contract tests stay green against the corrected cloud schema. The SignOptions docstring on `incidentClass` and the field reference in typescript/README.md now spell out the six valid values rather than the imprecise "DORA ITS code" paraphrase. Five new tests cover the canonical namespace shape, alias-into-canonical invariant, parametrised acceptance of all six values, legacy-alias forwarding, and the pre-HTTP rejection of unknown tokens. * docs(changelog): note DORA vocabulary correction for Python 0.3.11 / TS 0.2.9 The next release of both SDKs will surface DORA_INCIDENT_CLASS_NAMESPACE and LEGACY_DORA_ALIASES, plus client-side validation that mirrors the cloud's PR jagmarques#194 schema. Calls out the JC 2024-33 Annex II field 3.23 citation (final RTS published 17 July 2024) and the doc / help-text sweep that replaced the imprecise "DORA ITS vocabulary" gloss with the canonical six-value list. Versions intentionally not yet bumped in pyproject.toml / package.json; release tooling owns that step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds local-only AI session artefact patterns to
.gitignore:.claude/.planning/.company/COMPANY.mdCLAUDE.md(this repo does not track contributor rules; asqav cloud is the canonical home)Why
Audit (2026-05-18) found that 11 of 12 Asqav-org repos lack the AI-artefact
.gitignorepatterns. No leak today (all.claude/dirs in this repo are empty), but a future session creating a.claude/settings.jsonor.planning/discuss.mdcould accidentally get committed. This closes the gap.This repo already had
.claude/,.planning/, and.company/; this PR adds the missingCOMPANY.mdandCLAUDE.mdpatterns.Test plan
.gitignorenow lists the five patterns.git statusdoes not list.claude/,.planning/,.company/,COMPANY.md, orCLAUDE.mdafter this PR lands.comment hygiene clean