#2541 move screenshots to docker#2542
Merged
yaRnMcDonuts merged 8 commits intojMonkeyEngine:masterfrom Aug 9, 2025
Merged
Conversation
…cpu openGL we are using to avoid instability when new versions come out
Use "ClassName.TestName" format for test names in reports. This change improves traceability by associating tests with their respective classes, making debugging and analysis more intuitive.
Member
Author
|
@yaRnMcDonuts This should fix the screenshot tests (and make us no longer vulnerable to version changes). Other pipelines will fail until this is merged |
This was referenced Aug 9, 2025
Closed
Member
|
Thanks for the fix! If everything is ready here, then I'll go ahead and merge this in a few hours so that the tests are fixed for other PRs asap (however let me know if you want me to wait any longer) |
Member
Author
|
Yes please, as soon as possible would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR achieves the following
Fixes #2541
The docker image being used is created with https://github.com/oneMillionWorlds/opengl-docker-image (if we wanted that could be moved into jMonkeyEngine world and a jMonkeyEngine branded docker container created)