Refactor: BoundingSphereDebug optimization + javadoc#2465
Closed
capdevon wants to merge 3 commits intojMonkeyEngine:masterfrom
Closed
Refactor: BoundingSphereDebug optimization + javadoc#2465capdevon wants to merge 3 commits intojMonkeyEngine:masterfrom
capdevon wants to merge 3 commits intojMonkeyEngine:masterfrom
Conversation
Optimize code for geometry data generation
capdevon
changed the title
codex128
reviewed
Aug 6, 2025
Contributor
codex128
left a comment
codex128
left a comment
There was a problem hiding this comment.
Just a couple minor things that could be change to improve the code. I'm fine with this being merged now, though.
| private void setIndexData() { | ||
|
|
||
| // allocate connectivity | ||
| int nbSegments = (radialSamples) * 3; // 3 circles |
Contributor
There was a problem hiding this comment.
This variable can be inlined.
| // Each circle has radialSamples + 1 vertices (to close the loop) | ||
| // We have 3 circles, so (radialSamples + 1) * 3 vertices in total. | ||
| FloatBuffer posBuf = BufferUtils.createVector3Buffer(numVertices * 3); | ||
| FloatBuffer colBuf = BufferUtils.createVector3Buffer(numVertices * 4); |
Contributor
There was a problem hiding this comment.
This is technically correct, but is confusing since colBuf is for storing colors with 4 components. I suggest changing this to BufferUtils.createFloatBuffer(numVertices * 4 * 3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes result in a cleaner, more robust, and easier-to-understand
BoundingSphereDebugimplementation.BoundingSphereDebugclass for improved clarity and maintainability.write()andread()methods for theradialSamplesproperty.