Fix IndexError raised for single operand IMUL instruction#321
Merged
disinvite merged 1 commit intoisledecomp:masterfrom Feb 14, 2026
Merged
Fix IndexError raised for single operand IMUL instruction#321disinvite merged 1 commit intoisledecomp:masterfrom
IndexError raised for single operand IMUL instruction#321disinvite merged 1 commit intoisledecomp:masterfrom
Conversation
disinvite
force-pushed
the
fix-single-operand-imul
branch
from
fb08443 to
acf8986
Compare
jonschz
approved these changes
Feb 14, 2026
Collaborator
jonschz
left a comment
jonschz
left a comment
There was a problem hiding this comment.
Good to merge, assuming you have checked that the test fails on the old code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A group of instructions like this breaks the recent
mov/imulswap correction in #314:This fix aborts the attempted fix if we get a single-operand
imul.