Annotations and repository metadata - #1762
Open
foxtacles wants to merge 1 commit into
Open
Conversation
foxtacles
force-pushed
the
stack-01-annotations
branch
2 times, most recently
from
September 1, 2026 00:27
ca63f85 to
1f7252f
Compare
disinvite
reviewed
Sep 1, 2026
disinvite
reviewed
Sep 1, 2026
disinvite
reviewed
Sep 1, 2026
disinvite
approved these changes
Sep 1, 2026
foxtacles
force-pushed
the
stack-01-annotations
branch
12 times, most recently
from
September 3, 2026 21:10
92c7530 to
2e01105
Compare
SYMBOL-form annotations with mangled names, recovered BETA10 function addresses, library annotation headers (msvc, smack, smartheap, new CONFIG/library_dx.h), ncc skip entries for upcoming 1997 identifier restorations, gitattributes byte-stability rules, and the .clang-format include policy (stop reordering includes; 1997 seating follows). No object-code change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Go9hpkbGxzV6BU1BEsWs9E
foxtacles
force-pushed
the
stack-01-annotations
branch
from
September 4, 2026 03:00
2e01105 to
294c7e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYMBOL-form annotations with mangled names, recovered BETA10 function
addresses, library annotation headers (msvc, smack, smartheap, new
CONFIG/library_dx.h), ncc skip entries for upcoming 1997 identifier
restorations, gitattributes byte-stability rules, and the .clang-format
include policy (stop reordering includes; 1997 seating follows). No
object-code change.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_0111kigpi1MsEfGHfvJgGjRv
Why the name-based annotations move to
SYMBOLformThe
TEMPLATE/SYNTHETICmarkers previously carried the demangled display name and were matched against the comparison pipeline's rendering of the same symbol. That rendering is demangler-dependent. The same destructor:classkeywords, comma spacing, and> >vs>>all differ between demangler generations, and distinct symbols (e.g. constructor overloads) can even demangle to identical display strings. Under the strict comparison gate this stack builds toward — every row at 100% and every annotated function compared — an annotation that fails to resolve is a CI failure, not a skipped row.The mangled symbol is renderer-independent and unique by construction (it is the identity the linker itself folds COMDATs by), so these markers now use the
SYMBOLform documented by reccmp, which routes them through exact symbol matching instead of display-text matching.Stack context: part of the stacked delivery of #1761 (byte-identical reproduction of LEGO1.DLL, ISLE.EXE, and CONFIG.EXE). This layer is verified by the standard CI gates (builds, format, naming, annotations, exports/vtables/data compare). Byte-identity to retail is an emergent property of the complete stack and is re-proven by the ReproBit gates in the final PR of the stack (#1773).
Stack created with GitHub Stacks CLI • Give Feedback 💬