Skip to content

Deduplicate GR00T PYTHONPATH bootstrap logic#528

Merged
xyao-nv merged 3 commits intofeature/isaac_lab_3_newtonfrom
xyao/lab3/groot_deps_path_2
Apr 1, 2026
Merged

Deduplicate GR00T PYTHONPATH bootstrap logic#528
xyao-nv merged 3 commits intofeature/isaac_lab_3_newtonfrom
xyao/lab3/groot_deps_path_2

Conversation

@alexmillane
Copy link
Copy Markdown
Collaborator

@alexmillane alexmillane commented Apr 1, 2026

Summary

Deduplicate GR00T PYTHONPATH bootstrap logic

Detailed description

  • Duplicate GR00T PYTHONPATH bootstrapping code existed in policy_runner.py and conftest.py, risking divergence.
  • Extracted into a shared ensure_groot_deps_in_path() in isaaclab_arena_gr00t/utils/groot_path.py with a reexec_argv parameter to support both script and pytest re-exec. Updated both call sites to use it.
  • Add TODO to remove it in v0.3

@xyao-nv xyao-nv marked this pull request as ready for review April 1, 2026 15:27
@xyao-nv
Copy link
Copy Markdown
Collaborator

xyao-nv commented Apr 1, 2026

Since #523 stalls, let's merge this.

@xyao-nv xyao-nv changed the title Xyao/lab3/groot deps path 2 Deduplicate GR00T PYTHONPATH bootstrap logic Apr 1, 2026
@xyao-nv xyao-nv merged commit 6decc4a into feature/isaac_lab_3_newton Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants