Merged
Conversation
71c6264 to
08b9633
Compare
…nce_objects, fix wp2torch in g1_wbv_embodiment
Pinocchio was previously imported before AppLauncher as a workaround to force version resolution at startup. Isaac Lab 3 / Newton no longer requires this workaround, so all early pinocchio imports and the --disable_pinocchio CLI flag are removed. Changes: - Remove --disable_pinocchio arg from isaaclab_arena_cli.py - Remove pre-AppLauncher pinocchio imports from all scripts (train, play, teleop, record_demos, replay_demos, annotate_demos, generate_dataset, notebooks) - Remove enable_pinocchio param from test subprocess helpers - Remove peg/hole skip decorators from assembly and asset registry tests - Unconditionally import pick_place and enable XR detection where previously gated on enable_pinocchio Signed-off-by: Clemens Volk <cvolk@nvidia.com>
The hf binary installed in Isaac Sim's Python couldn't find 'requests' because Isaac Sim bundles it in a zip only accessible via python.sh. Use pipx to install hf into an isolated venv so all deps are available, without touching system Python packages.
Support Quest3 for loco-manipulation teleop and record/replay - What was the reason for the change? Support Quest3 for loco-manipulation teleop for g1_pink example. This allows proper data recording for the locomanipulation. - What has been changed? Adds openxr + g1_pink teleop support Adds documention for locomanip data recording with Quest
## Summary To fix tests hang on CI ## Detailed description Split the CI test step into two separate pytest invocations: 1. Run subprocess-spawning tests (test_policy_runner.py, test_sequential_task_mimic_data_generation.py) — each subprocess gets exclusive GPU access, runs, and exits cleanly 2. Run all remaining in-process tests with --ignore flags — these share the persistent SimulationApp as intended
fe70941 to
cd7d42a
Compare
## Summary Try to fix CI stalls affecting the Lab 3.0 branch. ## Detailed description - Caused by `run_subprocess` being called when a persistent simulation app is open. --------- Signed-off-by: Xinjie Yao <xyao@nvidia.com> Co-authored-by: Xinjie Yao <xyao@nvidia.com>
## Summary The requirement of RigidBodyAP at root level of prim path has been relaxed. Fall back to the source object path.
## Summary The URL used in Sphinx's mapping (docs.scipy.org/doc/numpy/) is legacy. NumPy moved its documentation to its own domain. Updated conf.py.
alexmillane
commented
Mar 31, 2026
Collaborator
Author
alexmillane
left a comment
There was a problem hiding this comment.
Not too bad!
|
|
||
| container: | ||
| image: nvcr.io/nvstaging/isaac-amr/isaaclab_arena:latest | ||
| image: nvcr.io/nvstaging/isaac-amr/isaaclab_arena:lab3 |
Collaborator
Author
There was a problem hiding this comment.
Remember to switch this back to latest post merge to main
|
|
||
| container: | ||
| image: nvcr.io/nvstaging/isaac-amr/isaaclab_arena:cuda_gr00t_gn16 | ||
| image: nvcr.io/nvstaging/isaac-amr/isaaclab_arena:lab3_cuda_gr00t_gn16 |
| on: | ||
| push: | ||
| branches: [ "main" ] | ||
| branches: [ "main", "feature/isaac_lab_3_newton" ] |
Collaborator
Author
There was a problem hiding this comment.
remove this post merge
| "pyarrow>=14,<18" \ | ||
| "av==12.3.0" \ | ||
| "aiortc==1.10.1" | ||
| "aiortc==1.10.1" && \ |
Collaborator
Author
There was a problem hiding this comment.
@xyao-nv What's the intention of having these trailing && \
I guess this chains all the commands together, but I've never seen that before. Is there a reason for doing this?
Collaborator
There was a problem hiding this comment.
I'll clean up in later MR.
isaaclab_arena_environments/gr1_put_and_close_door_environment.py
Outdated
Show resolved
Hide resolved
isaaclab_arena_examples/relations/dummy_object_placer_notebook.py
Outdated
Show resolved
Hide resolved
## Summary Address my self-review on the Isaac Lab 3.0 branch ## Detailed description - Small cleanups.
## Summary - Move g1 teleop pipeline into isaaclab_arena_g1/teleop folder per https://github.com/isaac-sim/IsaacLab-Arena/pull/464/changes#r3015546224 - Cleanup the logic for isaac_teleop_cfg / device_cfg resolution in arena_env_builder per https://github.com/isaac-sim/IsaacLab-Arena/pull/464/changes#r3015607024 and https://github.com/isaac-sim/IsaacLab-Arena/pull/464/changes#r3015632003 - Add typing for get_teleop_device_cfg from DeviceRegistry. This could be IsaacTeleopCfg for openxr devices, or native DeviceCfg for keyboard/spacemouse - Fix scripts not using device_cfg from the arena_env_builder properly
## Summary Doc changes only, refactor task concept page. ## Detailed description - Moved the Sequential Tasks section from concept_tasks_design.rst into a new standalone page concept_sequential_tasks_design.rst - Replaced the original section with a brief summary and cross-reference link to the new page - Registered the new page in the docs/index.rst toctree under the Concepts section
## Summary Deduplicate GR00T PYTHONPATH bootstrap logic ## Detailed description - Duplicate GR00T PYTHONPATH bootstrapping code existed in policy_runner.py and conftest.py, risking divergence. - Extracted into a shared ensure_groot_deps_in_path() in isaaclab_arena_gr00t/utils/groot_path.py with a reexec_argv parameter to support both script and pytest re-exec. Updated both call sites to use it. - Add TODO to remove it in v0.3 --------- Co-authored-by: Xinjie Yao <xyao@nvidia.com>
xyao-nv
approved these changes
Apr 1, 2026
cvolkcvolk
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the working branch for upgrading Isaac Lab Arena to Lab 3.0 with Newton.
Detailed description