Add inout workaround for GLSL on NVIDIA drivers#6
Open
pushrax wants to merge 1 commit intoiryoku:masterfrom
Open
Add inout workaround for GLSL on NVIDIA drivers#6pushrax wants to merge 1 commit intoiryoku:masterfrom
pushrax wants to merge 1 commit intoiryoku:masterfrom
Conversation
The NVIDIA GLSL compiler has a discrepancy causing array-typed function arguments declared with the "out" parameter qualifier to not update the caller's input. Whether this is a driver bug or not is debatable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some NVIDIA GLSL compilers have a discrepancy causing array-typed function arguments declared with the "out" parameter qualifier to not update the caller's input. Whether this is a driver bug or not is debatable, but in any event this workaround should support all cases.
This was reported on the NVIDIA forums a little while ago by someone else: https://devtalk.nvidia.com/default/topic/777925/opengl/varying-array-set-inside-function-using-quot-out-quot-fails/
@xthexder thanks for finding this one!