Open
Conversation
ScottTodd
requested changes
Jun 3, 2022
| pip freeze | egrep 'iree|tensorflow' | ||
| python -m pip install flake8 pytest | ||
|
|
||
| - name: Lint with flake8 |
Member
There was a problem hiding this comment.
Lint checks should be added in a separate action that runs on pull requests. This action is just for daily regression testing.
|
|
||
| - name: Lint with flake8 | ||
| run: | | ||
| # stop the build if there are Python syntax errors or undefined names |
Member
There was a problem hiding this comment.
Is the repo actually lint clean? We shouldn't add new blocking lint checks if they aren't yet green.
Comment on lines
+34
to
+36
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics --exclude lit.cfg.py | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics --exclude lit.cfg.py |
Member
There was a problem hiding this comment.
I don't have a strong opinion on this particular lint check, since I don't contribute to this repo often. However, my general impression is that this repo is less stringent with style, testing, code review, etc. so these checks may be a little heavy to introduce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.