Skip to content

fix: addrs factory skipping logic - #76

Merged
lidel merged 3 commits into
mainfrom
sukun/fix-addrs-factory
Jul 30, 2025
Merged

fix: addrs factory skipping logic#76
lidel merged 3 commits into
mainfrom
sukun/fix-addrs-factory

Conversation

@sukunrt

@sukunrt sukunrt commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@sukunrt
sukunrt requested a review from lidel July 29, 2025 11:43
@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.04%. Comparing base (0835788) to head (5dd4417).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   61.68%   62.04%   +0.35%     
==========================================
  Files          11       11              
  Lines        1219     1220       +1     
==========================================
+ Hits          752      757       +5     
+ Misses        394      391       -3     
+ Partials       73       72       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sukunrt
sukunrt requested a review from aschmahmann July 30, 2025 14:55
@lidel lidel changed the title fix addrs factory skipping logic fix: addrs factory skipping logic Jul 30, 2025
@github-actions

Copy link
Copy Markdown

Suggested version: 0.6.1

Comparing to: v0.6.0 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# summary
Suggested version: v0.6.1

gocompat says:

HEAD is now at 0835788 chore: release v0.6.0 (#74)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@lidel lidel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Added tests for reachable and non-reachable ipv4/6 to ensure there is no future regression.

This will be released as v0.6.1

@lidel
lidel merged commit bdc3d05 into main Jul 30, 2025
12 of 13 checks passed
@lidel
lidel deleted the sukun/fix-addrs-factory branch July 30, 2025 16:09
@lidel lidel mentioned this pull request Jul 30, 2025
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants