Skip to content

ui(fix): remove video base models from image aspect/ratio logic #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psychedelicious merged 1 commit into from
Sep 3, 2025
Merged

ui(fix): remove video base models from image aspect/ratio logic #8521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions ...rontend/web/src/features/parameters/components/Dimensions/DimensionsAspectRatioSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ import {
zFluxKontextAspectRatioID,
zGemini2_5AspectRatioID,
zImagen3AspectRatioID,
zRunwayAspectRatioID,
zVeo3AspectRatioID,
} from 'features/controlLayers/store/types';
import { selectIsRunway, selectIsVeo3 } from 'features/parameters/store/videoSlice';
import type { ChangeEventHandler } from 'react';
import { memo, useCallback, useMemo } from 'react';
import { useTranslation } from 'react-i18next';
Expand All @@ -35,8 +32,6 @@ export const DimensionsAspectRatioSelect = memo(() => {
const isImagen4 = useAppSelector(selectIsImagen4);
const isFluxKontext = useAppSelector(selectIsFluxKontext);
const isGemini2_5 = useAppSelector(selectIsGemini2_5);
const isVeo3 = useAppSelector(selectIsVeo3);
const isRunway = useAppSelector(selectIsRunway);

const options = useMemo(() => {
// Imagen3 and ChatGPT4o have different aspect ratio options, and do not support freeform sizes
Expand All @@ -52,15 +47,9 @@ export const DimensionsAspectRatioSelect = memo(() => {
if (isGemini2_5) {
return zGemini2_5AspectRatioID.options;
}
if (isVeo3) {
return zVeo3AspectRatioID.options;
}
if (isRunway) {
return zRunwayAspectRatioID.options;
}
// All other models
return zAspectRatioID.options;
}, [isImagen3, isChatGPT4o, isImagen4, isFluxKontext, isGemini2_5, isRunway, isVeo3]);
}, [isImagen3, isChatGPT4o, isImagen4, isFluxKontext, isGemini2_5]);

const onChange = useCallback<ChangeEventHandler<HTMLSelectElement>>(
(e) => {
Expand Down